On 06/29/10 10:39 AM, [email protected] wrote:
On Mon, Jun 28, 2010 at 11:01:37PM -0700, Shawn Walker wrote:
webrev:
http://cr.opensolaris.org/~swalker/pkg-format/
...
modules/config.py:
- Could you add some more documentation to this module? I'm not
really sure what all of these different property classes do.
There's a docstring on each class that describes its purpose and general
restrictions.
It would be nice to knoe more about the overall design for this
configuration format too.
The configuration format is dependent on the class that's used to write
the configuration. With that said, the FileConfig class uses
ConfigParser's format and for that I can update the docstring for the
class. Beyond that, I'm not sure what else I would do.
- line 1173: If both the encode and decode fail, this will append the
original value of 'v' to nvalue. Is this the desired behavior for
this failure case?
Yes, to permit arbitrary 8-bit data. The idea is to ensure ascii data
is a string object, unicode data gets turned into a unicode object, and
opaque data is left as a string object.
Thanks,
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
