On 06/23/10 10:17 PM, Danek Duvall wrote:
I've completed the prep work for this, so might as well send it out for
code review:

     http://cr.opensolaris.org/~dduvall/pkg-nativepkg/

.hgignore:
  While you're here -- it'd be nice to ignore tests/.coverage* and
  tests/htmlcov/ too...

src/Makefile:
  copyright needs update

  General: Is this executing the pkg commands from the proto area?
    Doesn't seem to be, but I might be missing something.

  lines 87-88: This should become (as of changeset 1968):
    pkgrepo create $@
    pkgrepo set-property publisher/prefix=$(PKGPUBLISHER)

My makefile-fu is weak, but otherwise this overall looks good to me. Please note that some of the recent putbacks I've made have changed what files we deliver for 'package/pkg'.

Cheers,
-Shawn


_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to