Tim Foster wrote:
> Hi Danek,
>
> On Fri, 2010-07-16 at 15:17 -0700, Danek Duvall wrote:
> > I've posted a new webrev for this, incorporating people's comments, and
> > tweaking a few more things:
> >
> > http://cr.opensolaris.org/~dduvall/pkg-nativepkg-2/
>
> I took a look at this - I noticed during the build that we're not
> calling pkgdepend, is that intentional?
Yes. The bug tracking that is
http://defect.opensolaris.org/bz/show_bug.cgi?id=16021
and all its dependencies are bugs or RFEs for pkgdepend that need to be
resolved before we can start using it.
> Not running it also means that we don't get the opensolaris.smf.fmri
> attribute set automatically.
Like everything else that pkgdepend currently does, we can do that
manually. I'll add that in.
> I also ran pkglint over the manifests, giving
>
> ERROR pkglint.manifest003 variant.arch not declared in
> pkg:/developer/opensolaris/[email protected],5.11-0.144
> ERROR pkglint.manifest003 variant.arch not declared in
> pkg:/system/trusted/[email protected],5.11-0.144
>
> Should we be reporting the variant.arch errors for these? I know they're
> group packages, so perhaps this lint check needs to be changed only
> complain if the package delivers actions other than 'set' and 'depend'.
If the package is identical across all instances of a variant, why should
that variant be declared? I'm willing to put those in, but it seems a
little odd.
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
