Hi Danek, On Fri, 2010-07-16 at 15:17 -0700, Danek Duvall wrote: > I've posted a new webrev for this, incorporating people's comments, and > tweaking a few more things: > > http://cr.opensolaris.org/~dduvall/pkg-nativepkg-2/
I took a look at this - I noticed during the build that we're not calling pkgdepend, is that intentional? I know we have a good idea of our dependencies anyway, but I think it'd be nice to run pkgdepend, if only as a best-practice should others choose these Makefiles to extend for their own projects. Not running it also means that we don't get the opensolaris.smf.fmri attribute set automatically. I also ran pkglint over the manifests, giving ERROR pkglint.manifest003 variant.arch not declared in pkg:/developer/opensolaris/[email protected],5.11-0.144 ERROR pkglint.manifest003 variant.arch not declared in pkg:/system/trusted/[email protected],5.11-0.144 Should we be reporting the variant.arch errors for these? I know they're group packages, so perhaps this lint check needs to be changed only complain if the package delivers actions other than 'set' and 'depend'. cheers, tim > An incremental is available here: > > http://cr.opensolaris.org/~dduvall/pkg-nativepkg-1-2/ > > The major changes are: > > - SVr4 package generation moved into its own makefile > > - Importer-side changes to classify the ips consolidation as "native" > > - Changes to the ipkg brand package so that the resulting package can > actually be installed on the current system > > I'm running the gate bits on my system; it was a simple operation once > entire was removed and I fixed that last bug. > > Thanks, > Danek > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
