Shawn Walker wrote: > On 06/23/10 10:17 PM, Danek Duvall wrote: > >I've completed the prep work for this, so might as well send it out for > >code review: > > > > http://cr.opensolaris.org/~dduvall/pkg-nativepkg/ > > .hgignore: > While you're here -- it'd be nice to ignore tests/.coverage* and > tests/htmlcov/ too...
Yeah, next time we do a coverage wad, we can do this. > src/Makefile: > copyright needs update Ah, thanks. > General: Is this executing the pkg commands from the proto area? > Doesn't seem to be, but I might be missing something. No, it's not. I'll try to figure out how to do this, but the idea was to get all the necessary changes in a build or two ahead of time and simply require that build to make the packages. So this might end up in a separate wad. > lines 87-88: This should become (as of changeset 1968): > pkgrepo create $@ > pkgrepo set-property publisher/prefix=$(PKGPUBLISHER) Ditto. > My makefile-fu is weak, but otherwise this overall looks good to me. > Please note that some of the recent putbacks I've made have changed > what files we deliver for 'package/pkg'. Thanks, I'll go figure that out. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
