On 08/ 2/10 03:33 PM, [email protected] wrote:
Folks,
The following is a relatively small code review that takes a bunch of
different generator functions from the transport and combines them into
a single routine with options. These functions were starting to sprout
tentacles, and it seemed better to combine all functionality in a single
routine. This change also introduces the ability for the transport to
take a list of supported version numbers, and return the highest
supported version found at a particular endpoint. We'll need this once
file/1 support is integrated.
http://cr.opensolaris.org/~johansen/webrev-16642/
Thanks,
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
In general, this LGTM. One question I had was whether certain operations
should imply that single_repository is True?
To double check, for publishing, the expectation would be that
origin_only and single_repository would both be true?
Does it make sense to do lines 1689-1701 if versions is an empty
list/None? Shouldn't those lines be in an else block to go with the if
on line 1685?
Thanks,
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
