[email protected] wrote:
> http://cr.opensolaris.org/~johansen/webrev-16642-2/
Pretty much just nits:
repo.py:
- are the two copies of supports_version() the same? If so, shouldn't
they be in the parent class?
transport.py:
- line 1623: anything to be said about how single_repository chooses
which repo to use? Arbitrary?
- line 1625: it might be worth mentioning that iff versions is passed,
then the yielded values are tuples
- line 1681: probably shouldn't have side-effects on versions. Perhaps
versions = sorted(versions, reverse=True)?
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
