Hi Brock, Thanks for looking at this.
On Mon, Aug 02, 2010 at 05:03:17PM -0700, Brock Pytlik wrote: > On 08/ 2/10 03:33 PM, [email protected] wrote: > > http://cr.opensolaris.org/~johansen/webrev-16642/ > > In general, this LGTM. One question I had was whether certain > operations should imply that single_repository is True? Publication operations should always set single_repository to True, but I can't think of a combination of arugments that we could use to infer that single_repository should be set to True automatically. > To double check, for publishing, the expectation would be that > origin_only and single_repository would both be true? Yes, that's correct. > Does it make sense to do lines 1689-1701 if versions is an empty > list/None? Shouldn't those lines be in an else block to go with the > if on line 1685? Yes. This code should only do one or the other. I've switched the order around, and made sure that the cases are either or, not both. Here's a new webrev: http://cr.opensolaris.org/~johansen/webrev-16642-2/ It also includes the fix for 16705. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
