Hi Danek, Thanks for looking at this. On Tue, Aug 03, 2010 at 03:58:01PM -0700, Danek Duvall wrote: > [email protected] wrote: > > > http://cr.opensolaris.org/~johansen/webrev-16642-2/ > > Pretty much just nits: > > repo.py: > > - are the two copies of supports_version() the same? If so, shouldn't > they be in the parent class?
The parent class is abstract. The only methods it defines are static methods. The supports_version() function manipulates instance data that's specific to FileRepo and HTTPRepo. I would have put this in the parent, but it doesn't have the properties that the function references. > transport.py: > > - line 1623: anything to be said about how single_repository chooses > which repo to use? Arbitrary? If single_repository is True and more than one repository is found, we'll get an AssertionError. It's up to the software that configures the transport to ensure that Publishers created for publication operations only have a single origin. > - line 1625: it might be worth mentioning that iff versions is passed, > then the yielded values are tuples Thanks, I meant to do this. > - line 1681: probably shouldn't have side-effects on versions. Perhaps > versions = sorted(versions, reverse=True)? I'm not sure that it matters here, but you're right that it's probably better not to do this. I'll change this to what you've suggested. Thanks, -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
