Shawn Walker wrote:
> http://cr.opensolaris.org/~swalker/pkg-2775/
The way that reinstall seems to be implemented, it smells a lot like
"upgrade". That is, there are no restrictions against using it to uprev
the version of a package, and it should be easy to do by simply saying "pkg
reinstall foo". Perhaps that's intentional. So what we have (eventually)
is:
pkg install upgrades a package or adds it to the system
pkg reinstall upgrades or downgrades a package, but will not add it
pkg upgrade upgrades a package, but will neither downgrade nor add
Seems like the overlap might be unnecessary. Should we have "upgrade" and
"downgrade", each of which enforces their name? Should we have a single
command that upgrades by default to the latest, but can take you to any
arbitrary revision if requested? Should a combined upgrade/downgrade
command require a flag to downgrade you? A future RFE might be to take you
to the most recently previously installed version of a package; how might
that fit in?
client.py:
- line 4441: This comes out to 75 characters, which fits on one line
nicely.
pkg.1.txt:
- I think rather than splitting install and uninstall out and addint
reinstall as another, mostly similar, subcommand, we might want to keep
them together, particularly since we're also considering the "update"
subcommand, which is going to be again mostly similar.
Perhaps have the full text for install and for reinstall, after
explaining what it does and why you'd use it, just refer the reader to
the section on install for an explanation for all options and
arguments. Ditto for uninstall, noting which of the options aren't
valid.
- If you're going to reflow the paragraphs, please set the right margin
at 75 characters; that's generally what we've been using. I'm not sure
where 70 came from; Solaris nroff sets it at 65. But don't reflow
anything other than what you're changing.
- I think you need more explanation in reinstall why it's necessary, and
what would happen if you specified an fmri that either matched packages
that weren't installed, or were newer than ones currently installed
(that is, in a non-downgrade scenario).
- I think the description of "install" needs some work. It doesn't have
to fit into one sentence, and I think would benefit from being expanded
a bit more. I'm happy to come up with something if you like.
file.py:
- line 356: "old version" here means the one currently installed -- i.e.,
the higher version -- right? At least, that's the semantics I would
expect.
api.py:
- line 423: noexecute really determines only the history?
- line 424: The referent for "It" is ambiguous.
imageplan.py:
- line 255, 336, 1533: extra indent needed
- line 1416: "pattens" -> "patterns"
pkg_solver.py:
- line 163: need to document trim_proposed_installed.
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
