On 09/13/10 06:07 PM, [email protected] wrote:
...
On Fri, Sep 10, 2010 at 06:48:19PM -0700, Shawn Walker wrote:
Greetings,

The following webrev contains changes for the following items:

   2775 pkg should provide a way to downgrade (reinstall) packages
   15462 pkg install subcommand needs to indicate it can be used for
update too

webrev:
http://cr.opensolaris.org/~swalker/pkg-2775/
...
actions/file.py:

   - line 154: Does this code need any special handling for a situation
     where it doesn't recognize the preserve type?  I'm assuming we do
     nothing for backward compatibility, but I didn't know if this should
     log a warning, or disable any additional behavior if the type is
     unrecognized.

I think if anything needed to be done here, it should be done as a separate changeset. The additional preserve type I've added here is a dynamic one only meant for the file action's own internal use.

I believe I've resolved all of your other comments and will send out an updated webrev soon.

Cheers,
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to