This looks good to me. Padraig
On 02/ 8/11 10:27 PM, Tim Foster wrote:
Hi there, I've a small webrev here that I'd appreciate a code review of please? (it'd be good to get a review from someone familiar with the GUI code too - I've manually verified that the GUI loads and pulls the correct file, but would like another pair of eyes, just in case) http://cr.opensolaris.org/~timf/move-opensolaris-sections-webrev It changes where we deliver the opensolaris.org.sections file, from being shipped as part of the gui, to being shipped as part of pkg. As suggested offline by David, I'm also adding new cat/subcats as a place to hold incorporations and group packages that don't easily fit elsewhere. I'd expect that a group package that grouped components of an office suite would still get an info.classification value of "Applications/Office", but it was less clear where pkg:/consolidation/osnet/osnet-redistributable should live, for example. cheers, tim _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
