Brock Pytlik wrote:
> http://cr.opensolaris.org/~bpytlik/ips-18240-v1/
A handful of quick nits:
Be sure to update copyright dates -- I see a lot of 2010.
sysrepo.p5m:
- why group sys for these things, and why the explicit mode=0444 and
user=root?
zoneproxy-client.xml:
- does this really need to be started as root?
- this mentions a zoneproxy-client(1M) manpage, but you don't have one.
zoneproxy/Makefile:
- No need to be so wimpy with the optimization -- you should be able to
fire that up to -xO4.
zoneproxy/list/Makefile:
- Why all these extra CFLAGS?
zoneproxy-adm/Makefile:
- No need to append -I../zoneproxyd to CPPFLAGS; Makefile.constants does
that for you. (Same for zoneproxy-client.)
zoneproxy-adm/zoneproxy-adm.c:
- line 58: this doesn't constitute a failure?
zoneproxyd/Makefile:
- should we actually be linking against libumem by default?
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
