On 05/ 3/11 02:57 PM, Danek Duvall wrote:
Brock Pytlik wrote:
On 05/ 3/11 02:12 PM, Danek Duvall wrote:
Brock Pytlik wrote:
http://cr.opensolaris.org/~bpytlik/ips-18240-v1/
[snip]
zoneproxy/list/Makefile:
- Why all these extra CFLAGS?
They matched what it was compiled w/ in other places. I'm happy to remove
any/all which should be gone.
The two debug flags (-g, -xdebugformat) should definitely go. I'm not sure
why the -W0 flag is there; since you don't have -xipo here, I would think
it's useless. I could take or leave -v. The -xcode flag is not necessary,
since you're not actually creating a shared library. Given that, -DPIC in
CPPFLAGS shouldn't be necessary, either.
Ok.
zoneproxy-adm/zoneproxy-adm.c:
- line 58: this doesn't constitute a failure?
I don't think so? I think it means that the zoneproxy-d isn't running. I
guess I can make it a failure. To hopefully avoid needless round trips,
is the right thing to do to print an error then call exit (1)?
That's what I'd do. But if it's okay that it exits 0 when the daemon isn't
running, that's okay; it just seemed wrong to me.
I checked w/ K on a couple of other things and he said that since proxyd
is multi-threaded, that libumem was a win.
Thanks,
Brock
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
