On 05/ 3/11 02:12 PM, Danek Duvall wrote:
Brock Pytlik wrote:
http://cr.opensolaris.org/~bpytlik/ips-18240-v1/
A handful of quick nits:
Be sure to update copyright dates -- I see a lot of 2010.
Well, at lot of these things were written in 2010 and haven't been
changed since. I thought I remembered you having a similar situation and
leaving the copyrights @ 2010. If I've misunderstood, I'm happy to
change them.
sysrepo.p5m:
- why group sys for these things, and why the explicit mode=0444 and
user=root?
I'm not sure honestly, I'll remove those bits.
zoneproxy-client.xml:
- does this really need to be started as root?
I'll check w/ K.
- this mentions a zoneproxy-client(1M) manpage, but you don't have one.
Yep, I'll file a bug to add a man page or I can remove the mention.
zoneproxy/Makefile:
- No need to be so wimpy with the optimization -- you should be able to
fire that up to -xO4.
Ok.
zoneproxy/list/Makefile:
- Why all these extra CFLAGS?
They matched what it was compiled w/ in other places. I'm happy to
remove any/all which should be gone.
zoneproxy-adm/Makefile:
- No need to append -I../zoneproxyd to CPPFLAGS; Makefile.constants does
that for you. (Same for zoneproxy-client.)
Thanks, I forgot to take that out.
zoneproxy-adm/zoneproxy-adm.c:
- line 58: this doesn't constitute a failure?
I don't think so? I think it means that the zoneproxy-d isn't running. I
guess I can make it a failure. To hopefully avoid needless round trips,
is the right thing to do to print an error then call exit (1)?
zoneproxyd/Makefile:
- should we actually be linking against libumem by default?
I've no idea. I'm happy to remove it.
Brock
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
