On 04/16/2015 06:14 PM, Christopher Baines wrote: > I am looking for a sponsor for openstreetmap-carto.
Some comments about the packaging follow. debian/gbp.conf is missing, it's a very good idea to add a gbp.conf file to (at minimum) use pristine-tar by default so you don't need to use the commandline option manually each time. See: http://pkg-grass.alioth.debian.org/policy/policy.html#debian-gbp.conf The two entries in debian/changelog can be merged into a single one because the previous upstream release hasn't been uploaded. See also: https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-debian-changelog The Vcs-* URLs are commented out in debian/control, these should be uncommented and updated to use the canonical URLs for the pkg-grass git repository. The Maintainer field lists Debian OpenStreetMap Team <pkg-osm-ma...@lists.alioth.debian.org>, but it should use Debian GIS Project <pkg-grass-devel@lists.alioth.debian.org>. I strongly recommend to use the cme utility to reformat the control file after you've made the fixes for the above. See: http://pkg-grass.alioth.debian.org/policy/policy.html#cme You should also update the package to conform to the latest (3.9.6) Debian Policy version, use the checklist to see what changes to expect: https://www.debian.org/doc/debian-policy/upgrading-checklist.html#s-3.9.6.0 The debian/copyright file can use some tweaks too, the Source URL enclosed in <> is uncommon, just the URL is sufficient. See also: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#source-field The order of the License and Files sections is in reverse order, the standalone license specifications are typically at the end of the copyright file. See: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#stand-alone-license-paragraph Because the CC0 license is not included in the common-licenses package, you need to specify the full license text in the License specification. http://creativecommons.org/publicdomain/zero/1.0/legalcode The debian/README.source is just the debhelper template and should be removed. The style.xml generated in debian/rules can more easily be installed via the debian/install file so you don't need the dh_auto_install override. Since this is a file generated during the package build, you need to take care to also remove it with dh_clean. The watch file downloads the tarballs from GitHub, but doesn't mangle the filename so you'll get tarball like v2.29.1.tar.gz. You should always mangle the filename for GitHub project as documented on the Wiki and in the uscan man page: https://wiki.debian.org/debian/watch#GitHub http://manpages.debian.org/cgi-bin/man.cgi?query=uscan&manpath=Debian+unstable+sid You should also consider adding upstream metadata, to document the upstream bug tracker, VCS and other relevant information. See: http://wiki.debian.org/UpstreamMetadata Kind Regards, Bas -- GPG Key ID: 4096R/6750F10AE88D4AF1 Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1 _______________________________________________ Pkg-grass-devel mailing list Pkg-grass-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-grass-devel
