On 04/17/2015 07:02 PM, Christopher Baines wrote:
> On 17/04/15 17:58, Sebastiaan Couwenberg wrote:
>> On 04/17/2015 06:52 PM, Christopher Baines wrote:
>>> Thanks so much for your feedback, I have now hopefully applied nearly
>>> all of this.
>>
>> Thanks, can you push the changes to Alioth?
>>
>> Don't forget to also push your tags, see:
>>
>> http://pkg-grass.alioth.debian.org/policy/packaging.html#push-package-to-alioth
> 
> Sorry, I thought I may have forgotten to push :)

Thanks for the push!

debian/po/templates.pot still has the unsubstituted template header:

# SOME DESCRIPTIVE TITLE.
# Copyright (C) YEAR THE PACKAGE'S COPYRIGHT HOLDER
# This file is distributed under the same license as the PACKAGE package.
# FIRST AUTHOR <EMAIL@ADDRESS>, YEAR.

You should change this to something like:

# openstreetmap-carto debconf templates.
# Copyright (C) 2014 Christopher Baines <m...@cbaines.net>
# This file is distributed under the same license as the
openstreetmap-carto package.
# Christopher Baines <m...@cbaines.net>, 2014.


The lack of translations currently results in a
no-complete-debconf-translation informational lintian issue, see:

https://lintian.debian.org/tags/no-complete-debconf-translation.html

You should send the request for translations after the package passes
the NEW queue into the archive.


The debian/copyright file still had the unneeded <> around the Source
URL, I've pushed a change to address that and one to fix the Upstream-Name.


I strongly suggest to add upstream metadata to documented the URLs for
the upstream infrastructure.

https://wiki.debian.org/UpstreamMetadata#Fields

For GitHub based projects this would suffice:

---
Bug-Database: https://github.com/gravitystorm/openstreetmap-carto/issues
Bug-Submit: https://github.com/gravitystorm/openstreetmap-carto/issues/new
Name: OpenStreetMap Carto
Repository: https://github.com//gravitystorm/openstreetmap-carto.git
Repository-Browse: https://github.com/gravitystorm/openstreetmap-carto


I currently don't have a tile server setup to test the package with
mapnik. What setup do you use?


Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1

_______________________________________________
Pkg-grass-devel mailing list
Pkg-grass-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-grass-devel

Reply via email to