On 17/04/15 19:14, Sebastiaan Couwenberg wrote: > On 04/17/2015 07:02 PM, Christopher Baines wrote: >> On 17/04/15 17:58, Sebastiaan Couwenberg wrote: >>> On 04/17/2015 06:52 PM, Christopher Baines wrote: >>>> Thanks so much for your feedback, I have now hopefully applied nearly >>>> all of this. >>> >>> Thanks, can you push the changes to Alioth? >>> >>> Don't forget to also push your tags, see: >>> >>> http://pkg-grass.alioth.debian.org/policy/packaging.html#push-package-to-alioth >> >> Sorry, I thought I may have forgotten to push :) > > Thanks for the push! > > debian/po/templates.pot still has the unsubstituted template header: > > # SOME DESCRIPTIVE TITLE. > # Copyright (C) YEAR THE PACKAGE'S COPYRIGHT HOLDER > # This file is distributed under the same license as the PACKAGE package. > # FIRST AUTHOR <EMAIL@ADDRESS>, YEAR. > > You should change this to something like: > > # openstreetmap-carto debconf templates. > # Copyright (C) 2014 Christopher Baines <[email protected]> > # This file is distributed under the same license as the > openstreetmap-carto package. > # Christopher Baines <[email protected]>, 2014.
Thanks, pushed. > The lack of translations currently results in a > no-complete-debconf-translation informational lintian issue, see: > > https://lintian.debian.org/tags/no-complete-debconf-translation.html > > You should send the request for translations after the package passes > the NEW queue into the archive. > > > The debian/copyright file still had the unneeded <> around the Source > URL, I've pushed a change to address that and one to fix the Upstream-Name. Thanks. > I strongly suggest to add upstream metadata to documented the URLs for > the upstream infrastructure. > > https://wiki.debian.org/UpstreamMetadata#Fields > > For GitHub based projects this would suffice: > > --- > Bug-Database: https://github.com/gravitystorm/openstreetmap-carto/issues > Bug-Submit: https://github.com/gravitystorm/openstreetmap-carto/issues/new > Name: OpenStreetMap Carto > Repository: https://github.com//gravitystorm/openstreetmap-carto.git > Repository-Browse: https://github.com/gravitystorm/openstreetmap-carto Thanks, also pushed. > I currently don't have a tile server setup to test the package with > mapnik. What setup do you use? I have been documenting setting up tileservers here [1]. Obviously hopefully this will improve if a package for openstreetmap-carto is available. This uses mod_tile/renderd which is also not in Debian, this is currently blocking on it including a copy of libiniparser. I am planning to have a play with tilelite and tilestache soonish, as they are available in Debian. Hopefully adjusting the wiki accordingly. 1: https://wiki.debian.org/OSM/tileserver/jessie _______________________________________________ Pkg-grass-devel mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-grass-devel
