On Thu, May 27, 2010 at 10:34, Felipe Sateler <fsate...@gmail.com> wrote: > On Thu, May 27, 2010 at 03:54, Jonas Smedegaard <d...@jones.dk> wrote: >> On Thu, May 27, 2010 at 09:09:15AM +0200, Reinhard Tartler wrote: >>> >>>> Yeah - tests should be composed so that _failure_ triggers alternative >>>> action: >>>> >>>> test ! -d .git || dh_quilt_unpatch >>> >>> oh right, thanks for pointing this out. >>> >>> Is this a basis for consensus? Shall we agree on this variant for the >>> clean rule? >> >> No. >> >> a) I believe it has not been verified to work with build daemons > > There has to be patching too in the build rule. dpkg-buildpackage > calls clean before build, so at clean it would unpatch, and at build > it would fail or silently build broken packages. That is why csound > failed to build when it was uploaded with a similar snippet
Hmm, soryy, that is not correct (the csound part). The csound snippet was not protected by .git directory testing. -- Saludos, Felipe Sateler _______________________________________________ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers