On Thu, Jan 13, 2011 at 10:16:41AM +0100, IOhannes m zmoelnig wrote:
On 2011-01-12 22:04, Jonas Smedegaard wrote:
On Wed, Jan 12, 2011 at 09:14:40PM +0100, Alessio Treglia wrote:
The clean target in debian/rules needs some work:

Looks like new upstream "release" ships with automade files.

Then sure it needs changes: The previous "release" needed them generated during build, and thus - for VCS sanity - carefully cleaned up as well.

See commit 7329d.

ah, i thought the reason for all this was, that some patches (autoconf_removed_sources.patch and system_gsm.patch) will modify configure.ac and Makefile.am, so the autotools have to be re-run.

since running autotools will then modify some files, i don't see a clean solution to make the "clean" target indeed restore upstream.

what do you propose?
- - patch configure/Makefile.in instead of configure.ac/Makefile.am?
- - add a pre-configure target that creates backups of the to-be-modified
files and restores them on clean?
- - ...

Patches to autogenerated files might be applied in wrong order, and thus potentially cause semi-random FTBFS.

Yes, I would preserve the to-be-regenerated files, and restore in clean.

See liblrdf for an example of doing that tightly. Or tell me if you have ideas to do it more elegantly :-)

 - Jonas

 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

Attachment: signature.asc
Description: Digital signature

pkg-multimedia-maintainers mailing list

Reply via email to