Hi Am 07.07.2016 um 14:30 schrieb Arturo Borrero Gonzalez: > On 29 June 2016 at 11:31, Arturo Borrero Gonzalez
>> Hi, just uploaded the update package to mentors.d.n. >> You can also find the sources in the git repo. >> >> Would you please review and sponsor? Small nit: Please use consistent identation for your Depends. The indentation of iptables' Depends and iptables-dev's Depends is off. Please use spaces everywhere consistently and not a tabs+spaces mix iptables-dev: You don't need the libiptc0, libip4tc0, libip6tc0 in Depends, they will be pulled in by their corresponding -dev package. Also, please consider lowering the priority of the library packages to optional. I know lintian will complain about that not being policy compliant, but I think installing libraries because of their priority is a stupid idea (and discussion is currently ongoing to fix the debian policy in that regard). The library packages should all probably be Multi-Arch: same, otherwise marking iptables M-A: foreign is pretty pointless. libiptc0, libip4tc0 and libip6tc0 don't need a Replaces: iptables (<< 1.6.0-3) Breaks: iptables (<< 1.6.0-3) You moved the library files to multi-arch paths, so there is no file conflict there with the old iptables package. The -dev packages are different, because they have conflicting paths with the old iptables-dev package. Thanks, Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Pkg-systemd-maintainers mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-systemd-maintainers
