On 14 July 2016 at 03:02, Michael Biebl <[email protected]> wrote: > > Small nit: Please use consistent identation for your Depends. > The indentation of iptables' Depends and iptables-dev's Depends is off. > Please use spaces everywhere consistently and not a tabs+spaces mix > > iptables-dev: You don't need the libiptc0, libip4tc0, libip6tc0 in > Depends, they will be pulled in by their corresponding -dev package. > > Also, please consider lowering the priority of the library packages to > optional. I know lintian will complain about that not being policy > compliant, but I think installing libraries because of their priority is > a stupid idea (and discussion is currently ongoing to fix the debian > policy in that regard). > > The library packages should all probably be Multi-Arch: same, otherwise > marking iptables M-A: foreign is pretty pointless. > > libiptc0, libip4tc0 and libip6tc0 don't need a > Replaces: iptables (<< 1.6.0-3) > Breaks: iptables (<< 1.6.0-3) > > You moved the library files to multi-arch paths, so there is no file > conflict there with the old iptables package. > The -dev packages are different, because they have conflicting paths > with the old iptables-dev package. >
Thanks Michael, just uploaded to mentors a new version with all of this changes. Would you please review and sponsor? best regards. -- Arturo Borrero González _______________________________________________ Pkg-systemd-maintainers mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-systemd-maintainers
