aacid added inline comments. INLINE COMMENTS
> dakon wrote in pam_kwallet.c:730 > Check return code. I would prefer to use open()/read()/close() directly, but > that can be seen as a matter of personal preferences. I can check the return code but does it matter? we'll write into the pipe anyway, be it 0 or whatever we read, if it's not the correct stuff the other process will fail anyway so i don't really see the need to complicate this code more than it already is with another extra if. > dakon wrote in pam_kwallet.c:750 > check for NULL the code i'm replacing didn't check for null, really y don't see the need, the code is half checking for null and half not, if you feel very strongly about checking for null maybe we can do it in a different patch and make sure all mallocs check for null? REPOSITORY R107 KWallet PAM Integration REVISION DETAIL https://phabricator.kde.org/D12937 To: aacid, dakon Cc: dakon, mgerstner, fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
