aacid added inline comments.

INLINE COMMENTS

> dakon wrote in pam_kwallet.c:749
> please use WIFEXITED and WEXITSTATUS here. The compiler is free to optimize 
> that into a simple compare if that's what it is, but you are now relying on 
> an implementation detail of that status code.

we're assuming status 0 and != 0 in other places of the code, i'll suggest to 
also fix this separately in a new patch

REPOSITORY
  R107 KWallet PAM Integration

REVISION DETAIL
  https://phabricator.kde.org/D12937

To: aacid, dakon
Cc: dakon, mgerstner, fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to