ngraham added a comment.
Thanks! The UI and behavior are now good. Code looks pretty sane too, just a
few style nitpicks:
INLINE COMMENTS
> kmenuedit.cpp:30
> #include <QIcon>
> +
> #include <KLocalizedString>
Unrelated change.
> kmenuedit.cpp:141
> + m_searchLine->setPlaceholderText(i18n("Search..."));
> + m_searchLine->setToolTip(i18n("Type to filter applications below"));
> +
Since the placeholder text says "Search..." we should probably not use the word
"Filter" in the tooltip. Also "Type to" isa not really necessary since that's
the only thing you can do with a search field. :)
How about something like "Search through the list of applications below"?
> kmenuedit.cpp:143
> +
> + auto treeLayout = new QVBoxLayout;
> + treeLayout->addWidget(m_searchLine);
No need to use `auto` here
> kmenuedit.cpp:146
> + treeLayout->addWidget(m_tree);
> + auto treeFrame = new QFrame;
> + treeFrame->setLayout(treeLayout);
No need to use `auto` here
> kmenuedit.cpp:157
>
> +
> connect(m_tree, SIGNAL(entrySelected(MenuFolderInfo*)),
Unrelated change
> treeview.cpp:1922
> +/*
> + * Workaround to set expansion of categories when search updates
> + */
I'm not sure this is actually working around anything; it's just a nice UI
behavior! :)
> treeview.h:208
>
> +
> protected:
Unrelated change
REPOSITORY
R103 KMenu Editor
REVISION DETAIL
https://phabricator.kde.org/D18939
To: tuxxi, ngraham, #plasma, cfeck
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
