tuxxi added inline comments. INLINE COMMENTS
> ngraham wrote in kmenuedit.cpp:143 > If there's nothing specifically in the style guidelines about it, it's best > to follow the existing coding style. Nothing else here uses `auto` with `new` > constructors, so we should follow the same style for new code. > > KDE software is multi-generational and it's important that each individual > developer not use their own personal preferred style instead of following the > existing style because that leads to the whole codebase becoming an > inconsistent mess over time. Cleanup can be desirable, but that should happen > separately, in its own patch, so it can be discussed on its own merits. Okay, makes sense. I'll try to be more atomic :) REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D18939 To: tuxxi, ngraham, #plasma, cfeck Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
