tuxxi added inline comments. INLINE COMMENTS
> ngraham wrote in kmenuedit.cpp:30 > Unrelated change. IMHO it looks cleaner to separate includes into categories, which is what I did here. > ngraham wrote in kmenuedit.cpp:141 > Since the placeholder text says "Search..." we should probably not use the > word "Filter" in the tooltip. Also "Type to" isa not really necessary since > that's the only thing you can do with a search field. :) > > How about something like "Search through the list of applications below"? I copied the tooltip text from KOpenWithDialog, but I'll change this one. Perhaps we can change it as well > ngraham wrote in kmenuedit.cpp:143 > No need to use `auto` here I'm using `auto` to avoid duplicating the type name when using `new` since the type is right there; its a habit I got into since clang-tidy recommends it. I couldn't find anything in the style guides prohibiting this. If you _really_ want, I can stop using `auto`. REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D18939 To: tuxxi, ngraham, #plasma, cfeck Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
