ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed.
Actually looking one more time I see a visual issue introduced by this patch: by putting the search field and list inside a frame, they both have bigger margins than the tabbed view to the right, so they don't line up anymore: F6612255: Screenshot_20190212_195729.png <https://phabricator.kde.org/F6612255> F6612252: Screenshot_20190212_195346.png <https://phabricator.kde.org/F6612252> Let's revert the `treeFrame` part, which should fix this. REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D18939 To: tuxxi, ngraham, #plasma, cfeck Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
