ralphy wrote: > I found the problem with the FDK AAC decoder segfaulting in the > community firmware. > > The aacDecoder_DecodeFrame API function multiplies the buffersize > provided in the parameters by the data size causing it to try accessing > beyond the allocated output buffer. > > https://github.com/ralph-irving/squeezeplay/blob/master/src/fdk-aac-2.0.1/libAACdec/src/aacdecoder_lib.cpp#L1960 > A good discovery !
ralphy wrote: > I found the problem with the FDK AAC decoder segfaulting in the > community firmware. > > Considering I wrote the aac decoder 18 months ago and this is the first > reported issue is pretty good and it took a "bug" in lms to expose it. > I would never had thought to test feeding mp3 data to the aac decoder. It's a very unfair world. :) I've attached some Radio logs that I was able to capture. They may or may not be helpful, but you might as well have them available. As you will see, from the Community firmware the predominate messages are, in the main -DEBUG audio.codec - decode_aac_callback_heaac:141 not enough bits-. The first log is not so clear, but I did not have full access before the Radio rebooted itself. We may just be seeing some 'last gasps'. Of interest, I think, is the Standard firmware log. Here we see -DEBUG audio.codec - src/decode_aac.c:124 sync error 4096 2148-. That makes me think the the standard firmware might have a stream synchronization step prior to submitting frames to the decoder proper, i.e. scanning the incoming stream for something that looks like AAC. Is such a step taken in the Community firmware ? I could imagine that a pre-scanning loop that glides over obviously duff data might improve resilience where a somewhat corrupted stream is present. What does -faad- do in terms of attempting synchronization ? I have no experience of this area. +-------------------------------------------------------------------+ |Filename: Radio log - Community firmware - 4.txt | |Download: http://forums.slimdevices.com/attachment.php?attachmentid=33052| +-------------------------------------------------------------------+ ------------------------------------------------------------------------ mrw's Profile: http://forums.slimdevices.com/member.php?userid=38299 View this thread: http://forums.slimdevices.com/showthread.php?t=113719 _______________________________________________ plugins mailing list [email protected] http://lists.slimdevices.com/mailman/listinfo/plugins
