The current recommended approach to use PoDoFo as a static library is
to add source "root" directory to includes: this allows to pick wrapper
headers in "root/podofo". This is, from my point of view, a poor solution
since it requires boilerplate wrappers that also must be kept in sync,
which is boring. Moreover the current headers force to use this layout,
since they reference other headers using folder "podofo" that must
be in the includes. Worse, it does it by using the #include "header.h"
notation which is in the list of my personal good practices to leave it
for relative paths. The current patch convert headers to really use
relative paths, allowing to use podofo with #include <podofo.h> notation.

I recommend to accept this patch to give more flexibility when using PoDoFo
as a static library. Additionally (or alternatively) I recommend to change the 
layout
of PoDoFo source to totally eradicate the need for wrapper headers. A possible
solution is to move all the actual source of PoDoFo to a "podofo" folder in
"root/src" directory. In this way one just put "root/src" in the includes
and can continue to use #include <podofo/podofo.h> notation with even less
pollution of include search paths.


Francesco Pretto (1):
  Used relative includes in headers

 src/base/PdfExtension.h            | 2 +-
 src/doc/PdfAcroForm.h              | 2 +-
 src/doc/PdfAction.h                | 2 +-
 src/doc/PdfAnnotation.h            | 2 +-
 src/doc/PdfCMapEncoding.h          | 4 ++--
 src/doc/PdfContents.h              | 2 +-
 src/doc/PdfDestination.h           | 8 ++++----
 src/doc/PdfDifferenceEncoding.h    | 4 ++--
 src/doc/PdfDocument.h              | 8 ++++----
 src/doc/PdfElement.h               | 4 ++--
 src/doc/PdfEncodingObjectFactory.h | 2 +-
 src/doc/PdfExtGState.h             | 4 ++--
 src/doc/PdfField.h                 | 6 +++---
 src/doc/PdfFileSpec.h              | 4 ++--
 src/doc/PdfFont.h                  | 6 +++---
 src/doc/PdfFontCID.h               | 2 +-
 src/doc/PdfFontCache.h             | 8 ++++----
 src/doc/PdfFontConfigWrapper.h     | 6 +++---
 src/doc/PdfFontFactory.h           | 2 +-
 src/doc/PdfFontFactoryBase14Data.h | 4 ++--
 src/doc/PdfFontMetrics.h           | 8 ++++----
 src/doc/PdfFontMetricsBase14.h     | 6 +++---
 src/doc/PdfFontMetricsFreetype.h   | 6 +++---
 src/doc/PdfFontMetricsObject.h     | 8 ++++----
 src/doc/PdfFontSimple.h            | 2 +-
 src/doc/PdfFontTTFSubset.h         | 2 +-
 src/doc/PdfFontTrueType.h          | 2 +-
 src/doc/PdfFontType1.h             | 2 +-
 src/doc/PdfFontType1Base14.h       | 2 +-
 src/doc/PdfFontType3.h             | 2 +-
 src/doc/PdfFunction.h              | 2 +-
 src/doc/PdfHintStream.h            | 4 ++--
 src/doc/PdfIdentityEncoding.h      | 6 +++---
 src/doc/PdfImage.h                 | 4 ++--
 src/doc/PdfInfo.h                  | 6 +++---
 src/doc/PdfMemDocument.h           | 6 +++---
 src/doc/PdfNamesTree.h             | 2 +-
 src/doc/PdfOutlines.h              | 2 +-
 src/doc/PdfPage.h                  | 8 ++++----
 src/doc/PdfPagesTree.h             | 4 ++--
 src/doc/PdfPagesTreeCache.h        | 2 +-
 src/doc/PdfPainter.h               | 6 +++---
 src/doc/PdfPainterMM.h             | 2 +-
 src/doc/PdfShadingPattern.h        | 4 ++--
 src/doc/PdfSignatureField.h        | 2 +-
 src/doc/PdfStreamedDocument.h      | 4 ++--
 src/doc/PdfTable.h                 | 8 ++++----
 src/doc/PdfTilingPattern.h         | 4 ++--
 src/doc/PdfXObject.h               | 8 ++++----
 49 files changed, 103 insertions(+), 103 deletions(-)

--
2.16.1.windows.1


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users

Reply via email to