Hi zyx, hello all, > On 24 January 2019 at 18:55 zyx <z...@gmx.us> wrote: > > > Hi, ... snip ... > > > @zyx: Are you still vetoing that change of Francesco's (making > > Unknown equal to 0xff in EPdfDataType)? > > My complain from the past was about the compiler warnings (as Francesco > pointed out in the archives). The two changes together (r1959 and the > proposal) will make it work flawlessly, without the warnings, thus my > original objection is gone. In other words, just do it.
Thank you very much :-). I'm so relieved because it didn't read so clearly before. > > > If not, I'll commit it after the fixes to the known security issues. > > Why to postpone? Why to split related commits by other commits? Originally because I planned to prioritize the security fixes. > Consider the r1959 caused this lengthy discussion. It would be more > than logic to close the discussion in the next revision, in r1960, not > to have some gap and only then finish something ongoing, while it's You've persuaded me, I have done the commit and it has indeed landed in svn r1960 [1] so that ends this discussion. > quite easy to forget of it. The changes I think of are: a) Unknown to > be 0xff; b) add comment above the change in r1959 explaining why it is > so. I would do a) and b) as one commit. The sooner you finish this In general I'd have treated them as two commits, because they don't depend on each other, but here, the elegance of "one finishing commit" swayed me. > two-liner the better. Now it's seven lines (with typo fixes and some reformatting as there is no 80-character limit followed in PdfVariant.h) ... Michal's assertion about space for a 32-bit enum is for another time, IMO (in the other thread originally about [PATCH 2/5]). > Bye, > zyx > Best regards, mabri _______________________________________________ Podofo-users mailing list Podofo-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/podofo-users
