Tal Moshaiov wrote: >Searching for a row RECORD will fail (this operation can only be done from the Sheet >object). Since Sheet does not use this method, >it is probably 2.0 > > Right, I mean: can a user of the high level API still find an HSSFRow? If so, I agree - 2.0.
Thanks, Andy >Tal > >----- Original Message ----- >From: "Andrew C. Oliver" <[EMAIL PROTECTED]> >To: "POI Developers List" <[EMAIL PROTECTED]> >Sent: Tuesday, May 21, 2002 5:11 PM >Subject: Re: RowRecordAggregate patch > > > > >>So let me get this clear: searching for a row in an existing >>spreadsheet doesn't work when you read it in? (if so that sounds like >>1.5.1, if not then 2.0) >> >>Tal Moshaiov wrote: >> >> >> >>>Andrew , >>> >>> >>> >>> >>> >>>>Can you explain what the patch fixes? >>>> >>>> >>>> >>>> >>>A bug for fetching RowRecords from the rows buffer (TreeMap) in RowRecordAggregate. >The request for a specific row is made using >>> >>> >its > > >>>row number, however the search in the tree used to search for the same row object. >>>I simply introduced a Comparator that compares two RowRecords using their row >number and not object equality. >>> >>> >>> >>> >>> >>>>What is the symptom? >>>> >>>> >>>> >>>> >>>RowRecordAggregate.getRow(..) doesn't work. >>>As far as I saw, no one used this method before me. >>> >>> >>> >>> >>> >>>>does it hurt people using 1.5 or can it wait until 2.0? >>>> >>>> >>>> >>>> >>>It can wait until 2.0 >>>However I believe it should be at least commited >>> >>>Tal >>> >>>----- Original Message ----- >>>From: "Andrew C. Oliver" <[EMAIL PROTECTED]> >>>To: "POI Developers List" <[EMAIL PROTECTED]> >>>Sent: Tuesday, May 21, 2002 4:39 PM >>>Subject: Re: using commons logging >>> >>> >>> >>> >>> >>> >>>>Can you explain what the patch fixes? What is the symptom? Meaning >>>>does it hurt people using 1.5 or can it wait until 2.0? >>>> >>>>Tal Moshaiov wrote: >>>> >>>> >>>> >>>> >>>> >>>>>Hi Andy, Glen ! >>>>> >>>>>You guys go ahead and decide to which release would you like to commit this one. >All I need is for this to be committed. >>>>> >>>>>BTW, I may submit a similar bugfix for the ValueRecordsAggregate. >>>>> >>>>>Thank you guys ! >>>>> >>>>>Regards >>>>>Tal >>>>>---------------------------------- >>>>>Tal Moshaiov >>>>>Applications Development >>>>>VistaPortal Software, Inc. >>>>>[EMAIL PROTECTED] >>>>>Phone: 972-3-6126188 >>>>>Fax: 972-3-6126189 >>>>>ICQ: 109104838 >>>>>www.vistaportal.com >>>>> >>>>> >>>>> >>>>>----- Original Message ----- >>>>>Glen, as I understand it you had concerns with this patch? Have they been >resolved? >>>>> >>>>>Tal, is this patch against 1.5 or against the head? Are you intending for it to >>>>>be applied and appear in 2.0 or a possible later 1.5 bugfix release? >>>>> >>>>>Once I get confirmation from you gentlemen on these issues I'll apply and commit. >>>>> >>>>>Thanks, >>>>> >>>>>Andy >>>>> >>>>> >>>>>-- >>>>>To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> >>>>>For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>-- >>>>To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> >>>>For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> >>>> >>>> >>>> >>>> >>>> >>>-- >>>To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> >>>For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> >>> >>> >>> >>> >>> >>> >> >> >>-- >>To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> >>For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> >> >> >> > > >-- >To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> >For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> > > > > -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
