I was offline for a couple of hours working on this, so noticed quite late the 
mails on this. anyways .. 

I have committed a fix to this bug to cvs head (Sorry for the multiple commits)

RowRecord already implements the comparable interface, with consistent equals 
and compareTo implementation. So just using a TreeMap gives you the behaviour 
you want, and there is not need for a comparator.  I have also added a test to 
check the required behaviour .. this failed for the old code, and passes with 
the new. (Actually, i thought hashmap also checks the equals method .. no? ... 
lot to learn, i guess?)

Tal, it would be helpful if you could check that your code works correctly with 
the new code from CVS?

ValueRecordAggregate already uses a treemap, and it seems all the 
CellValueRecordInterface implementations implement comparable. So this should 
be fine. (Tho, should we have CellValueRecordInterface itself extending 
comparable).  I'll write a test to check that out. Tal, tell me if it doesnt 
work for you. 

Cheers
-
Avik

PS. i have *almost* got the formula ref/value mess figured, tho not necessarily 
elegantly .. expect a commit in a day or two. 

Quoting "Andrew C. Oliver" <[EMAIL PROTECTED]>:

> Okay.. . to the head then. :-)  
> 

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to