On Tue, Apr 10, 2007 at 10:00:39PM +0200, Christian Rueger wrote: > Landry Breuil wrote: > [...]
Okay, so with feedback from Brad, Christian Rueger and Lawrence Teo, i've reworked some diffs.. thanks for the input on USE_BZIP2 vs EXTRACT_SUFX. I only updated core libs to 4.4.1 atm, which is a bugfix and translation update release.. working on the other ports in theses days. All the ports are built with USE_SYSTRACE, and the new SHA256 distinfo (snapshot from 14/4).. New patches are in http://gcu.info/~gaston/patches/xfce4.4.1 I added myself as MAINTAINER, feel free to discuss this.. i still have one problem for the 'general' Makefile.inc, i dunno if adding EXTRACT_SUFX there is the best solution, because only core Xfce libraries and apps are distributed as bz2, plugins and goodies are generally distributed as tgzs.. any hint for this ? Atm, i added EXTRACT_SUFX only where it is needed in the separate ports, on a case by case basis. I added USE_LIBTOOL=Yes to libxfcegui4 and libxfce4mcs, because imho they're needed for SHARED_LIBS version. Libs uses libtool anyway. What is the policy for SHARED_LIBS bump version ? only 0.1 when necessary ? rely on libtool output ? here for example, libxfce4mcs jumps from 2.3 to 3.5.. i've read http://www.openbsd.org/porting/update.html and didn't find info about it.. > > devel/libxfce4util : > > http://gcu.info/~gaston/patches/devel-libxfce4util.diff > > - patches/patch-Makefile_in is not any longer relevant. Nothing special > > here, only version bump.. > > we need this patch, to removing the gtk-docs Okay, but why removing html gtk-docs for the libraries ? vte/poppler/pango/cairo and friends still install them... > > - Why not move this port into x11/xfce4 too ? It'll be more 'consistent' > > with other Xfce libs... Again, what do you think about this ? i don't know apps others than xfce-apps using libxfce4util... updated version here : http://gcu.info/~gaston/patches/xfce4.4.1/devel-libxfce4util.diff > > x11/xfce4/libxfcegui4 : > > http://gcu.info/~gaston/patches/x11-xfce4-libxfcegui4.diff > > - databases/dbh and textproc/libxml are not dependencies anymore, byebye > > - don't know if MODGNU_SHARED_LIBS is still necessary > > remove PKGNAME, MODGNU_SHARED_LIBS, EXTRACT_SUFX > add to Makefile.inc done > > - patches not necessary > > we need this patch Same question, why removing gtk-docs ? place ? I don't bother, i only want to understand why :) Other three patches in modules/ are not relevant anymore. > @conflict xfce4-panel-4.2.3 for icons done, thanks for this.. how do you detect it ? upgrade pkg, PLIST_DB ? some icons moved from the panel to the lib in the upgrade.. updated version here : http://gcu.info/~gaston/patches/xfce4.4.1/x11-xfce4-libxfcegui4.diff > > x11/xfce4/libxfce4mcs : > > http://gcu.info/~gaston/patches/x11-xfce4-libxfce4mcs.diff > > - don't know if MODGNU_SHARED_LIBS is still necessary > > - patches not necessary > s.o. updated version here : http://gcu.info/~gaston/patches/xfce4.4.1/x11-xfce4-libxfce4mcs.diff > > > x11/xfce4/xfce-mcs-manager : > > http://gcu.info/~gaston/patches/x11-xfce4-xfce-mcs-manager.diff > > - nothing special > > > > x11/xfce4/xfce-mcs-plugins : > > http://gcu.info/~gaston/patches/x11-xfce4-xfce-mcs-plugins.diff > > - nothing special > > remove PKGNAME, EXTRACT_SUFX done, updated versions here : http://gcu.info/~gaston/patches/xfce4.4.1/x11-xfce4-xfce-mcs-manager.diff http://gcu.info/~gaston/patches/xfce4.4.1/x11-xfce4-xfce-mcs-plugins.diff > the rest need more test and review i'm still waiting for more feedback.. updates and corrections for other ports are coming soon, and i'm working on little quirks (sound plugin not shown in mcs-manager, thunar crash on sparc64, etc..) Don't hesitate to try and comment. Thanks, Landry
