On Wed, Dec 11, 2013 at 02:34:22PM +0100, Jérémie Courrèges-Anglas wrote:
> Claudio <claudiozu...@gmail.com> writes:
>
> > Is there a chance of getting this into ports if it's fine?
>
> There was a bit of cleanup to do before thinking about that.
> Here's another tarball, which fixes:
> - ordering of variables (see Makefile.template)
> - void CFLAGS and LDFLAGS; they were not passed to the build,
> same for FAKE_FLAGS
> - CFLAGS not respected, which leads to the build using -O3; use
> MAKE_FLAGS
> - dependency on gtk+3 (and not gtk+2)
> - manpage formatting, mandoc doesn't support the .po roff request.
> - DISTFILES handling using the less redundant distname{name}suffix
> syntax.
> - incomplete WANTLIB (+ gettext module)
> - out of sync Makefile patch (unneeded hunks and comments)
> - DESCR could give more information (is that enough?)
No need to LIB_DEPENDS on cairo/glib2, gtk+3 already does, and use tabs
instead of spaces (COMMENT, USE/NO_* lines..)
With that, looks ok to me.
Landry
