Landry Breuil <[email protected]> writes:

[...]

> No need to LIB_DEPENDS on cairo/glib2, gtk+3 already does,

Is "No need to" to be interpreted here as "should not", ie. a general
porting recommendation?

Upstream explicitely uses this:
  `pkg-config --libs gtk+-3.0 glib-2.0 cairo gio-2.0`

If for whatever reason our gtk+3 doesn't depend on cairo anymore the
deps will be out of sync.  And I see no problem with listing direct deps
explicitely.  This question is afaik not specific to gtk+3.

> and use tabs
> instead of spaces (COMMENT, USE/NO_* lines..)
>
> With that, looks ok to me.
>
> Landry

-- 
jca | PGP: 0x06A11494 / 61DB D9A0 00A4 67CF 2A90  8961 6191 8FBF 06A1 1494

Reply via email to