j...@wxcvbn.org (Jeremie Courreges-Anglas) writes:

> Some time ago I took a look at hooking lua53 flavors in the ports that
> support it.  It turned out that some ports were already broken with
> particular versions of lua (the most common errors are missing functions
> at dlopen time, and module() errors), yet they were hooked up.
> So it's not just about adding lua53 flavors, but about having
> a consistent ports tree.  In the end, I think that lua.port.mk should
> stop populating FLAVORS automatically, so that people hacking on lua
> have to explicitely enable the lua versions they tested.  Just like for
> python.port.mk.
> The diff to explicitely add FLAVORS / hook them up is not ripe yet,
> but first I'd like to know if people object to the proposal above.

afaik we can stop automatically adding FLAVORS in lua.port.mk; it would
be nice if someone could put this in a bulk to confirm.

Index: lua.port.mk
RCS file: /d/cvs/ports/lang/lua/lua.port.mk,v
retrieving revision 1.34
diff -u -p -p -u -r1.34 lua.port.mk
--- lua.port.mk 7 Jun 2016 11:51:52 -0000       1.34
+++ lua.port.mk 17 Oct 2016 13:34:49 -0000
@@ -10,18 +10,6 @@ CATEGORIES +=        lang/lua
 # Define the default version and use that if MODLUA_VERSION is not set.
-# If a port already has flavors, append our lua flavors to it, unless it
-# requests specific versions of lua. Otherwise set the FLAVORS list to
-# just the lua flavors.
-_MODLUA_FLAVORS =      lua52 lua53
-.if !defined(MODLUA_VERSION)
-.  if !defined(FLAVORS)
-FLAVORS ?=             ${_MODLUA_FLAVORS}
-FLAVORS +=             ${_MODLUA_FLAVORS}
-.  endif
 FLAVOR ?=              # empty
 # without a flavor, assume ${MODLUA_DEFAULT_VERSION}

jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply via email to