Jeremie Courreges-Anglas <j...@wxcvbn.org> writes:

> j...@wxcvbn.org (Jeremie Courreges-Anglas) writes:
>
>> Some time ago I took a look at hooking lua53 flavors in the ports that
>> support it.  It turned out that some ports were already broken with
>> particular versions of lua (the most common errors are missing functions
>> at dlopen time, and module() errors), yet they were hooked up.
>>
>> So it's not just about adding lua53 flavors, but about having
>> a consistent ports tree.  In the end, I think that lua.port.mk should
>> stop populating FLAVORS automatically, so that people hacking on lua
>> have to explicitely enable the lua versions they tested.  Just like for
>> python.port.mk.
>>
>> The diff to explicitely add FLAVORS / hook them up is not ripe yet,
>> but first I'd like to know if people object to the proposal above.
>
> afaik we can stop automatically adding FLAVORS in lua.port.mk; it would
> be nice if someone could put this in a bulk to confirm.

Committed, thanks Antoine for the bulk build test.

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply via email to