> With qt5 cmake-based ports it's intended that MODULES=x11/qt5 is used, > which sets these up automatically. Yes, I saw that, x11/qt5 sets all the DIRS at once, I prefer to keep that as it is. I would give you a better reason, but really is just because I did not wanted to use the "set all" method, minimalist ftw. The devel/cmake module is all that is needed after those environment variables.
> Not a major objection but tbh I'm not a huge fan of using a mailing list > as a MAINTAINER address. It was just to avoid spam. Take me as a full maintainer. > From a quick read through I think they're good enough to use, could > be tweaked a bit but it would be simpler to do this by sending diffs > after it's imported. Agreed. Now, if you say that "It it's looking pretty good so far", you should be also proud because teaching me a lot in the previous commits. :) But I'm not sure if you see the l10n folder. :( Cheers. Elias.
