Sorry for spamming but I added some things: - Some changes proposed by Stuart: -- use MODULES += x11/qt5 -- Bulk variables from l10n. - Change @exec to @tags.
Cheers. Elias. 2018-06-28 5:28 GMT-03:00 Stuart Henderson <[email protected]>: > On 2018/06/27 22:42, Elias M. Mariani wrote: >> > With qt5 cmake-based ports it's intended that MODULES=x11/qt5 is used, >> > which sets these up automatically. >> Yes, I saw that, x11/qt5 sets all the DIRS at once, I prefer to keep >> that as it is. >> I would give you a better reason, but really is just because I did not >> wanted to use the "set all" method, minimalist ftw. >> The devel/cmake module is all that is needed after those environment >> variables. > > Even if you're happy to figure out which DIRs are needed and set them, > using the module has a hidden advantage - because there's no single port > for qt5, if we want to identify ports using qt5 (for example to produce > a file to use in SUBDIRLIST to do a test build of ports using qt5), > the simple way to do this is: > > sqlite3 /usr/local/share/sqlports "select * from modules where > value='x11/qt5'" > >> > Not a major objection but tbh I'm not a huge fan of using a mailing list >> > as a MAINTAINER address. >> It was just to avoid spam. Take me as a full maintainer. > > You could always use a different address (either a full separate account, > or "plus addressing" i.e. [email protected] and use filters to > separate it). But your address is more likely to be collected from > mailing list posts rather than from MAINTAINER lines ;) > >> > From a quick read through I think they're good enough to use, could >> > be tweaked a bit but it would be simpler to do this by sending diffs >> > after it's imported. >> Agreed. >> >> Now, if you say that "It it's looking pretty good so far", you should >> be also proud because teaching me a lot in the previous commits. :) >> But I'm not sure if you see the l10n folder. :( > > heh - it's not too bad, but you could set COMMENTs in bulk, and default > PKGNAMEs (just override the ones which are different) - just PKGNAME is > enough for these, no need to touch FULLPKGNAME (usually that is only > needed when there are FLAVORs). > > --snip-- -- -- -- > # $OpenBSD: Makefile,v 1.58 2018/06/22 08:30:46 landry Exp $ > > VERSION = 0.13.0 > NAME= lxqt-l10n > > DISTNAME= ${NAME}-${VERSION} > > MULTI_PACKAGES += -about -config -compton-conf > MULTI_PACKAGES += -notificationd -openssh-askpass > MULTI_PACKAGES += -panel -policykit -powermanagement > MULTI_PACKAGES += -runner -session -sudo -libfm-qt > MULTI_PACKAGES += -main -lximage-qt -obconf-qt -pavucontrol-qt > MULTI_PACKAGES += -pcmanfm-qt -qterminal -qtermwidget > > .for i in ${MULTI_PACKAGES} > COMMENT$i = lxqt translations > # set standard PKGNAMEs, override below for some subpackages > PKGNAME$i = lxqt$i-l10n-${VERSION} > .endfor > > PKGNAME-libfm-qt = libfm-qt-l10n-${VERSION} > PKGNAME-main = liblxqt-l10n-${VERSION} > PKGNAME-compton-conf = compton-conf-l10n-${VERSION} > PKGNAME-lximage-qt = lximage-qt-l10n-${VERSION} > PKGNAME-obconf-qt = obconf-qt-l10n-${VERSION} > PKGNAME-pavucontrol-qt = pavucontrol-qt-l10n-${VERSION} > PKGNAME-pcmanfm-qt = pcmanfm-qt-l10n-${VERSION} > PKGNAME-qterminal = qterminal-l10n-${VERSION} > PKGNAME-qtermwidget = qtermwidget-l10n-${VERSION} > > BUILD_DEPENDS += x11/qt5/qtbase,-main \ > x11/qt5/qttools \ > x11/lxqt/build-tools > > CONFIGURE_ARGS += -DWITH_LXQT_ADMIN:BOOL=OFF > CONFIGURE_ENV += Qt5Core_DIR=${LOCALBASE}/lib/qt5/cmake > CONFIGURE_ENV += Qt5LinguistTools_DIR=${LOCALBASE}/lib/qt5/cmake > > > .include <bsd.port.mk> > --snip-- -- -- --
lxqt.tar.gz
Description: GNU Zip compressed data
