Hi all, I've been working on packages for Debian and (K)Ubuntu and work is progressing nicely. I've already been in contact with Danny and Holger so I hope they forgive me if I repeat myself. As the Debian packages for hal/dbus are outdated I packaged powersave-0.9.25/kpowersave-0.4.5 and these packages have just been uploaded to the official Debian archive. They are currently in the NEW queue and if everything goes right will be accepted the next days. For (K)Ubuntu I packaged powersave-0.10.19/kpowersave-0.5.0 and uploaded them to my private archive at: http://www.teco.edu/~biebl/ubuntu There is a short instruction how people can add this repository to their sources.list. If you want you may link to this page. I will however get in touch with the (K)Ubuntu people to get (k)powersave officially into their archive. But for now you can use my private repository as an interim solution.
So much for the good news ;-) During the packaging I encountered some problems/inconsistencies that I'm now going to itemise. I'll try to always specify the version and package in question. kpowersave: 1.) [0.4.5/0.5.0] Please distribute the autotools generated files with the tarball. The easiest way to achieve that is to use "make dist". For this 2.) [0.4.5] set the correct version in configure.in.in (AM_INIT_AUTOMAKE) 3.) [0.4.5/0.5.0] build path != source path not possible (make install fails). Fix: See attachement absolute_build_path_fix.diff 4.) [0.5.0] Please specifiy the mininum required versions of hal/dbus in configure.in.in. Does it really have to be 0.33/0.5.4 or is an older version sufficient? 5.) [0.4.5/0.5.0] Dependency to old Qt1/Qt2 headers, e.g. qvector.h. Imo it would be a good idea to use the Qt3 counterparts. 6.) [0.4.5/0.5.0] Path to sound files in settings dialog is hard coded to /opt/kde. Please use @prefix@ and respect the path that is already set, i.e. if the use has set e.g. /usr/share/sounds/bla/blub.ogg start with path /usr/share/sounds/bla/ and *not* the default path. 7.) [0.4.5/0.5.0] Use KDialogBase for settings dialog. That way the user settings are used (icons on buttons etc.) 8.) [0.4.5/0.5.0] If battery runs out I get xmessages that a powersaved event was received with no further informations. That is pretty useless imo. powersave: 9.) [0.9.25] No autotools generated files in tarball, fixed in 0.10.19 10.) [0.9.25/0.10.19] AUTHORS, ChangeLog, TODO, NEWS empty or missing. 11.) [0.9.25/0.10.19] /etc/acpi/events.ignore/events.ignore is installed with mode 744, should be 644. 12.) [0.9.25] /etc/sysconfig/powersave/disk has a shebang line at the beginning of the config file but is no bash script. 13.) [0.9.25/0.10.19] wttyhx installed to @prefix@/bin, why not to @prefix@/powersave/scripts? 14.) [0.9.25/0.10.19] so versioning: so version is pretty high. Is the API really that unstable? Did you really follow [1] for library versioning? I read a CVS commit saying that the so version was bumped to follow the package version increase. That is normally not the way to do it. 15.) [0.9.25/0.10.19] rcpowersaved: For Debian I don't install this script/link as this is not Debian style. If powersaved is not running kpowersave displays a warning message saying that you should use "/usr/sbin/rcpowersaved start". Maybe this error message could be rephrased. 16.) [0.9.25/0.10.19] Many scripts in /usr/lib/powersave have hard coded paths, e.g /opt/kde or /usr/bin. Either use binaries without path or determine correct path during ./configure (see Makefile.am/bin_SCRIPTS) 17.) [0.9.25/0.10.19] There is no grubonce in Debian. So changing the default bootentry is not working yet. Still looking for a good solution. 18.) [0.10.19] pam_console: Debian has not enabled pam_console support so the default dbus-1/system.d/powersave.conf is not working. I added a section similar to <policy at_console="true">..</policy> and replaced the policy with <policy group="plugdev">. 19.) [0.9.25/0.10.19] Dependency on /proc/acpi/sleep. If /proc/acpi/sleep support is disabled in kernel (deprecated since 2.6.13) powersave doesn't provide the suspend_to_ram option. If /proc/acpi/sleep is not found try /sys/power/state. Affected file: libpower/sleep.c 20.) [0.9.25/0.10.19] on_ac_power binary: name clash with powermgmt_base package. I don't know if this package exist in SuSE. For Debian I don't install on_ac_power from powersaved but add a Run-Dependency to powermgmt_base. I'm not sure if it has the same interface/output. How does on_ac_power have to behave? 21.) [0.9.25/0.10.19] function keyword in init script is a bashism. Do you really need bash specific features? Otherwise it would be good to use #!/bin/sh in script header and check the scripts with "checkbashisms". That way you can replace the default shell with something lighter like dash. 22.) [0.10.19] Typo in restore_after_suspend_to_disk line 44: "init.de" 23.) [0.10.19] What is the minimum required version for hal (configure.ac only checks the min version for dbus) 24.) [0.10.19] --enable-hal disables hal support ;-) Obviously not what you'd expect if you have a --disable-hal switch. 25.) [0.9.25/0.10.19] Dependency on apmd: The powersaved script complains and exits if apmd is running. Is it safe to enforce the removal of the apmd if powersaved gets installed or are there applications that need apmd and its tools? I intended to add "Conflicts: apmd" to the powersaved package so that apmd gets deinstalled if you want to install powersaved. Is that the Right Way(TM) in your opinion? 26.) [0.10.19] sleep_helper_functions: Detect if pccardctl or cardctl is installed and use the found binary. Do not expect a user to edit sleep_helper_functions and set the correct binary. Ideas: 27.) Enable/Set power management for wireless cards. Wireless cards demands lots of power. For working cards enable low power modes when on battery. 28.) Restore console resolution/state with vbetool. Don't know if it is safe to enable this but I find it quite annoying to switch to X and back to the console to restore the correct resolution of the console. 0.10.19 seems to have a script in contrib. 29.) Provide emulation for apmd. See point 25 for that. Would it be feasible to provide wrapper scripts like "apm" which provide the same interface as the original apm tools and call the corresponding powersave methods? 30.) DB for working combinations of hardware (laptop), used framebuffer(vesa,vga16,..), possible suspend states, needed boot parameters. It would be great if we would start to collect data of known working settings. For my case (HP nx7000) I had to disable radeonfb and use vesafb and set the boot parameter acpi_sleep=s3_bios,s3_mode in order to get suspend_to_ram working. We could use this data during postinst to preset the values in @sysconfdir@/powersave. Maybe we could set up a web form where user can enter there working setup. What would be needed then: - hardware - kernel revision - used framebuffer - boot flags - suspend2disk working - suspend2ram working Anything else? That would mean a great benefit imo for users if they don't have to experiment with different bootflags etc. and just get a working setup. I know the list got quite long and I've surely missed some points I wanted to address. Nevertheless I hope you all read till the end and give me some feedback on this points. Last but not least kudos to you all! I think (k)powersave is great software, let's try to make it better ;-) Cheers, Michael [1] http://sources.redhat.com/autobook/autobook/autobook_91.html -- ------------------------------------------------------------ E-Mail: [EMAIL PROTECTED] WWW: http://www.teco.edu/ TecO (Telecooperation Office) Vincenz-Priessnitz-Str.1 University of Karlsruhe 76131 Karlsruhe, Germany ------------------------------------------------------------
--- Makefile.am.in.orig 2005-11-03 15:13:06.000000000 +0100 +++ Makefile.am.in 2005-11-03 15:14:08.000000000 +0100 @@ -23,6 +23,6 @@ install-data-local: $(mkinstalldirs) $(DESTDIR)$(kde_confdir) - $(INSTALL_DATA) ./src/config/kpowersaverc_default $(DESTDIR)$(kde_confdir)/kpowersaverc + $(INSTALL_DATA) $(top_srcdir)/src/config/kpowersaverc_default $(DESTDIR)$(kde_confdir)/kpowersaverc #SUBDIRS=$(TOPSUBDIRS)
signature.asc
Description: OpenPGP digital signature
_______________________________________________ powersave-devel mailing list [email protected] http://forge.novell.com/mailman/listinfo/powersave-devel
