On Tuesday 15 November 2005 10:19, Holger Macht wrote: > > kpowersave: > > > > 1.) [0.4.5/0.5.0] Please distribute the autotools generated files with > > the tarball. The easiest way to achieve that is to use "make dist". > > This should be no problem because make dist should work with newer > versions of kpowersave
No Holger, this does not work at the moment with kpowersave, we need to fix this for make dist and make distcheck. > > For this > > 2.) [0.4.5] set the correct version in configure.in.in (AM_INIT_AUTOMAKE) We do this already for the newer versions. > > 3.) [0.4.5/0.5.0] build path != source path not possible (make install > > fails). Fix: See attachement absolute_build_path_fix.diff > > Thanks for the patch. I take a look at this > > 5.) [0.4.5/0.5.0] Dependency to old Qt1/Qt2 headers, e.g. qvector.h. > > Imo it would be a good idea to use the Qt3 counterparts. o.k. I removed the included header. Was not needed. Do you know which other headers are obsolete? Is there a way to check this automatically? > > 6.) [0.4.5/0.5.0] Path to sound files in settings dialog is hard coded > > to /opt/kde. Please use @prefix@ and respect the path that is already > > set, i.e. if the use has set e.g. /usr/share/sounds/bla/blub.ogg start > > with path /usr/share/sounds/bla/ and *not* the default path. > > > > 7.) [0.4.5/0.5.0] Use KDialogBase for settings dialog. That way the user > > settings are used (icons on buttons etc.) > > > > 8.) [0.4.5/0.5.0] If battery runs out I get xmessages that a powersaved > > event was received with no further informations. That is pretty useless > > imo. Hm, I never got this. What exactly was the message? Maybe a problem with powersave and sending a empty message?! > Do you look at these issues danny? Yes, I take a look at this. > > 10.) [0.9.25/0.10.19] AUTHORS, ChangeLog, TODO, NEWS empty or missing. > > I will add contents to the AUTHORS file. > > NEWS? We have none ;-) We try to file news items to sourceforge or > forge.novell.com regulary. I think it is pretty useless to have them > multiple times at different locations. Btw. would be nice to have this file also in the package. Maybe like at HAL informatation about the release and changes. > > 23.) [0.10.19] What is the minimum required version for hal > > (configure.ac only checks the min version for dbus) > > I'm not exactly sure about this. But 0.5x is not mandatory needed IMHO. I > hope Danny can tell us when the api changed the last time. If there are > unsupported information in ealier version, this should not matter because > then the information would simply not be available. Last big API change was 0.5.x . Danny _______________________________________________ powersave-devel mailing list [email protected] http://forge.novell.com/mailman/listinfo/powersave-devel
