On Tue 15. Nov - 10:19:00, Holger Macht wrote:
> On Tue 15. Nov - 04:38:57, Michael Biebl wrote:
[...]
> >
> > 20.) [0.9.25/0.10.19] on_ac_power binary: name clash with powermgmt_base
> > package. I don't know if this package exist in SuSE. For Debian I don't
> > install on_ac_power from powersaved but add a Run-Dependency to
> > powermgmt_base. I'm not sure if it has the same interface/output. How
> > does on_ac_power have to behave?
>
> Usage: on_ac_power [-q]
>
> returns 0 if on AC power or unable to determine ac state
> returns 1 if on battery power
> -q: quiet mode
>
> We did not know that there is a name clash. I will rename it. As far as I
> can see, it is used only at one point in helper_functions.
How does your on_ac_power from powermgmt_base behave? Does it return the
same information? Maybe we add a configure switch to not install our own
on_ac_power.
>
> >
> > 21.) [0.9.25/0.10.19] function keyword in init script is a bashism. Do
> > you really need bash specific features? Otherwise it would be good to
> > use #!/bin/sh in script header and check the scripts with
> > "checkbashisms". That way you can replace the default shell with
> > something lighter like dash.
>
> This would IMO be also good. But I'm not sure how much work this will
> cause. Stefan, can you estimate if there are many bash specific features
> in our scripts?
But you will need bash for our powersave scripts anyway. So it would not
help much if the init script is plain sh and your scripts won't work.
[...]
Thanks,
Holger
_______________________________________________
powersave-devel mailing list
[email protected]
http://forge.novell.com/mailman/listinfo/powersave-devel
