On Sat, Aug 19, 2006 at 08:34:17AM -0500, Pat Double wrote:
> I had trouble getting to work with my setup, I am using metalog. In fact 
> there 
> would be no log messages at all. It turns out the problem appears to be the 
> square braces in the tag line set in the LOGGER environment var. I removed 
> the braces and it works.

Ok. Does it work if you only remove the first braces, like
LOGGER="logger -t powersave-${MYNAME}[$$] "
This style is pretty common, e.g. in udev's firmware.sh, so i'd suppose
it should work.

Havong a closer look, the powersave-style with
[$progname][$pid]
is rather uncommon anyway, so we should probably change it to
$progname[$pid]
as everybody else does. If it additionally helps metalog, even better.

> Please comment if this is an acceptable change or if something else is 
> desirable. I just know that with the square braces I get nothing in the log. 
> BTW, metalog adds square braces around the tag.

If it does not workthe proposed change above, i have no problem changing it
to your version.

Do the daemon messages work for you? For example restarting HAL gives me the
following:
    Aug 27 10:43:40 susi [powersave]: WARNING (filter_function:208) Hal service 
stopped. Battery information no longer available
Maybe those are also broken with metalog (and hence the braces should also be
removed from the daemons messages?

> --- helper_functions.orig     2006-08-19 07:49:18.000000000 -0500
> +++ helper_functions  2006-08-16 12:45:10.000000000 -0500
> @@ -26,7 +26,7 @@
>  #
>  
>  MYNAME=${0##*/}
> -LOGGER="logger -t [powersave-${MYNAME}][$$] "
> +LOGGER="logger -t powersave-${MYNAME}-$$ "
>  
>  # these variables are set by the daemon in the environment before
>  # this script is executed
-- 
Stefan Seyfried                     | "Please, just tell people
QA / R&D Team Mobile Devices        |               to use KDE."
SUSE LINUX Products GmbH, Nürnberg  |          -- Linus Torvalds
_______________________________________________
powersave-devel mailing list
powersave-devel@forge.novell.com
http://forge.novell.com/mailman/listinfo/powersave-devel

Reply via email to