smiklosovic commented on a change in pull request #1046:
URL: https://github.com/apache/cassandra/pull/1046#discussion_r667032411
##########
File path: src/java/org/apache/cassandra/db/Keyspace.java
##########
@@ -337,6 +339,23 @@ public static void clearSnapshot(String snapshotName,
String keyspace)
return list;
}
+ public List<SnapshotDetails> getSnapshotDetails() {
+ List<SnapshotDetails> list = new ArrayList<>();
+ for (ColumnFamilyStore cfStore : getColumnFamilyStores())
+ {
+ Directories dirs = cfStore.getDirectories();
+ for (Map.Entry<String, Directories.SnapshotSizeDetails>
snapshotDetail : cfStore.getSnapshotDetails().entrySet())
+ {
+ String snapshotName = snapshotDetail.getKey();
+ File manifest = dirs.getSnapshotManifestFile(snapshotName);
Review comment:
@fibersel as discussed in the ticket already, I think this call is not
deterministic and it should be addressed. We should have a deterministic wait
to get a manifest for particular SnapshotDetails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
