smiklosovic commented on a change in pull request #1046:
URL: https://github.com/apache/cassandra/pull/1046#discussion_r667041465
##########
File path: src/java/org/apache/cassandra/db/SnapshotDetailsTabularData.java
##########
@@ -69,14 +75,28 @@
}
- public static void from(final String snapshot, final String ks, final
String cf, Map.Entry<String, Directories.SnapshotSizeDetails> snapshotDetail,
TabularDataSupport result)
+ public static void from(final String snapshot, final File manifestFile,
final String ks, final String cf, Map.Entry<String,
Directories.SnapshotSizeDetails> snapshotDetail, TabularDataSupport result)
Review comment:
@fibersel I think this might ideally also accept just expiresAt and
createdAt parameters in order to avoid the parsing of file with all its
complexities and it would be just simple stuff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
