smiklosovic commented on a change in pull request #1046: URL: https://github.com/apache/cassandra/pull/1046#discussion_r667037628
########## File path: src/java/org/apache/cassandra/db/SnapshotDetails.java ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.cassandra.db; + +import java.time.Instant; +import java.io.File; +import java.io.IOException; +import org.apache.cassandra.io.util.FileUtils; +import java.util.Map; +import org.apache.cassandra.config.Duration; + + + +public class SnapshotDetails { + public String tag; + public String keyspace; + public Instant createdAt; + public Instant expiresAt; + + public SnapshotDetails(String tag, String keyspace, File manifestFile) { + this.tag = tag; + this.keyspace = keyspace; + try + { + Map<String, Object> manifest = FileUtils.readFileToJson(manifestFile); Review comment: @fibersel if you extract the parsing of manifest file outside as advised by Paulo, I would actually do it in such a way that that SnapshotDetails would accept two more parameters - expiresAt and createdAt - in other words, the parser itself would give me this information comfortably so I do not need to deal with that in this constructor. There should not be any complicated logic in SnapshotDetails except some simple getters / setters. This should be mostly just a POJO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
