smiklosovic commented on a change in pull request #1046:
URL: https://github.com/apache/cassandra/pull/1046#discussion_r667047119
##########
File path: src/java/org/apache/cassandra/service/StorageService.java
##########
@@ -3891,16 +3908,18 @@ public void clearSnapshot(String tag, String...
keyspaceNames) throws IOExceptio
{
for (ColumnFamilyStore cfStore : keyspace.getColumnFamilyStores())
{
+ Directories dirs = cfStore.getDirectories();
for (Map.Entry<String, Directories.SnapshotSizeDetails>
snapshotDetail : cfStore.getSnapshotDetails().entrySet())
{
+ String snapshotName = snapshotDetail.getKey();
TabularDataSupport data =
(TabularDataSupport)snapshotMap.get(snapshotDetail.getKey());
if (data == null)
{
data = new
TabularDataSupport(SnapshotDetailsTabularData.TABULAR_TYPE);
snapshotMap.put(snapshotDetail.getKey(), data);
}
- SnapshotDetailsTabularData.from(snapshotDetail.getKey(),
keyspace.getName(), cfStore.getTableName(), snapshotDetail, data);
+ SnapshotDetailsTabularData.from(snapshotName,
dirs.getSnapshotManifestFile(snapshotName), keyspace.getName(),
cfStore.getTableName(), snapshotDetail, data);
Review comment:
@fibersel , again, ideally should accept just createdAt and expiresAt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
