maedhroz commented on a change in pull request #1045:
URL: https://github.com/apache/cassandra/pull/1045#discussion_r687054121
##########
File path: src/java/org/apache/cassandra/transport/PreV5Handlers.java
##########
@@ -63,19 +64,21 @@
* Note: should only be accessed while on the netty event loop.
*/
private long channelPayloadBytesInFlight;
- private boolean paused;
+
+ /** The cause of the current connection pause, or {@link
Overload#NONE} if it is unpaused. */
+ private Overload pauseTrigger = Overload.NONE;
Review comment:
In early versions of the patch, `paused` was simply removed because it
was functionally equivalent to checking `ChannelConfig#isAutoRead()`. So we
could add an `isPaused()` method, but I'm not sure what would use it, given
`releaseItem()` could not. (i.e. It needs to know why.)
Let me know if we should improve the comment there:
> // The only exception to this is if the global request rate limit has been
breached, which means
// we'll have to wait until a scheduled wakeup task unpauses the
connection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
