josh-mckenzie commented on a change in pull request #1045:
URL: https://github.com/apache/cassandra/pull/1045#discussion_r687756757
##########
File path: src/java/org/apache/cassandra/transport/CQLMessageHandler.java
##########
@@ -424,21 +482,46 @@ protected boolean
processFirstFrameOfLargeMessage(IntactFrame frame, Limit endpo
// concurrently.
if (throwOnOverload)
{
- // discard the request and throw an exception
+ // Mark as overloaded so that discard the message after
consuming any subsequent frames.
ClientMetrics.instance.markRequestDiscarded();
- logger.trace("Discarded request of size: {}.
InflightChannelRequestPayload: {}, " +
- "InflightEndpointRequestPayload: {},
InflightOverallRequestPayload: {}, Header: {}",
- messageSize,
- channelPayloadBytesInFlight,
- endpointReserve.using(),
- globalReserve.using(),
- header);
-
- // mark as overloaded so that discard the message
- // after consuming any subsequent frames
- largeMessage.markOverloaded();
+ logOverload(endpointReserve, globalReserve, header,
messageSize);
+ largeMessage.markOverloaded(Overload.BYTES_IN_FLIGHT);
+ }
+ }
+ else if
(DatabaseDescriptor.getNativeTransportRateLimitingEnabled())
+ {
+ if (throwOnOverload)
Review comment:
Same as above; this is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
